Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all string literals / regexp literals referencing RuntimeGlobals #16897

Closed
TheLarkInn opened this issue Mar 31, 2023 · 8 comments · Fixed by #18121
Closed

Replace all string literals / regexp literals referencing RuntimeGlobals #16897

TheLarkInn opened this issue Mar 31, 2023 · 8 comments · Fixed by #18121
Assignees
@TheLarkInn
Labels
performance X5: work required (PR / Help Wanted)

Comments

@TheLarkInn
Copy link
Member 

          We can reuse it from https://github.com/webpack/webpack/blob/main/lib/RuntimeGlobals.js#L11

Originally posted by @alexander-akait in #16896 (comment)
@TheLarkInn TheLarkInn self-assigned this Mar 31, 2023
@TheLarkInn
Copy link
Member Author

Been a bit swamped on this so looking for contributions here!

@snitin315
Copy link
Member

I can help with this.

@TheLarkInn
Copy link
Member Author

By all means. Happy to review it.

@dev-cj dev-cj mentioned this issue May 4, 2023
Closed
@dev-cj
Copy link

dev-cj commented May 4, 2023

I have mentioned a PR for this issue. Which only replaces the exact use of the string "webpack_require".

I was about to replace more references where concatenation or template strings were used with __webpack_require__ and where RuntimeGlobals was already imported. Should I continue with this in a new PR?
image

This was referenced May 19, 2023
Merged
Merged
@webpack-bot
Copy link
Contributor

This issue had no activity for at least three months.

It's subject to automatic issue closing if there is no activity in the next 15 days.

@webpack-bot
Copy link
Contributor

Issue was closed because of inactivity.

If you think this is still a valid issue, please file a new issue with additional information.

@cwj0417
Copy link
Contributor

cwj0417 commented Jan 8, 2024 •
edited

is this issue can be closed as complete? some PRs related to this issue is merged.

@alexander-akait
Copy link
Member

We need to check it, I think we still can optimize some strings in our code

@tthijm tthijm mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheLarkInn TheLarkInn

Labels
performance X5: work required (PR / Help Wanted)
Projects
webpack 5/6
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace remaining RuntimeGlobals references tthijm/webpack
7 participants
@TheLarkInn @alexander-akait @cwj0417 @webpack-bot @snitin315 @dev-cj and others