Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added assert/strict built-in #16766

Merged
merged 1 commit into from Mar 9, 2023
Merged

Added assert/strict built-in #16766

merged 1 commit into from Mar 9, 2023

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Mar 1, 2023

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 1, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: piranna / name: Jesús Leganés-Combarro (cb02826)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@alexander-akait
Copy link
Member

@TheLarkInn I think we can merge it, just small fix for Node env

@piranna
Copy link
Contributor Author

piranna commented Mar 9, 2023

@TheLarkInn I think we can merge it, just small fix for Node env

Thank you @alexander-akait, I don't know if there's any other built-in that we should add, I have just added this that's my personal case. I've seen that we are already currently checking for node: prefix, that's the recommended way, probably we should recommend it ourselves in the docs too.

@TheLarkInn TheLarkInn merged commit c989143 into webpack:main Mar 9, 2023
46 checks passed
@TheLarkInn
Copy link
Member

Thank you for the PR 💟

@piranna
Copy link
Contributor Author

piranna commented Mar 10, 2023

You are welcome :-)

@piranna piranna deleted the patch-1 branch March 10, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

None yet

5 participants