You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From all the comments and what I can see in the code, it seems that contextTimestamps is supposed to track directories while filesTimestamps are supposed to be for files. I ask the question because both Sets are initialized to be exact replicas of eachother.
In large repos, these are very large and expensive sets. Is it possible to simply collapse these and just use fileTimestamps? I ask now because if removing is a possibility, WP6 planning may be a good time for that.
See double initialization here
Plus extra computation here
I think a simple solution for the perf cost is to just initialize compiler.contextTimestamps to compiler.fileTimestamps and then just use the same set across all the places its used.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
From all the comments and what I can see in the code, it seems that
contextTimestamps
is supposed to track directories whilefilesTimestamps
are supposed to be for files. I ask the question because both Sets are initialized to be exact replicas of eachother.webpack/lib/node/NodeWatchFileSystem.js
Line 122 in c181294
webpack/lib/node/NodeWatchFileSystem.js
Line 129 in c181294
In large repos, these are very large and expensive sets. Is it possible to simply collapse these and just use
fileTimestamps
? I ask now because if removing is a possibility, WP6 planning may be a good time for that.See double initialization here
Plus extra computation here
I think a simple solution for the perf cost is to just initialize
compiler.contextTimestamps
tocompiler.fileTimestamps
and then just use the same set across all the places its used.cc @sokra
Beta Was this translation helpful? Give feedback.
All reactions