Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error handling for WebsocketServer #5038

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Fix #5018

Breaking Changes

Additional Info

Sorry, something went wrong.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (48f56d5) 91.94% compared to head (3cece2c) 91.96%.

Files Patch % Lines
lib/servers/WebsocketServer.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5038      +/-   ##
==========================================
+ Coverage   91.94%   91.96%   +0.01%     
==========================================
  Files          15       15              
  Lines        1577     1580       +3     
  Branches      600      600              
==========================================
+ Hits         1450     1453       +3     
  Misses        118      118              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test case or a small todo to add a test case, I know it is the right solution, but I don't have time right now to test it

@snitin315
Copy link
Member Author

added a todo.

@alexander-akait alexander-akait marked this pull request as ready for review February 2, 2024 11:29
@alexander-akait
Copy link
Member

Tests are stable on linux and windows, but still unstable on macos I will look in future

@alexander-akait alexander-akait merged commit 975c719 into master Feb 2, 2024
@alexander-akait alexander-akait deleted the fix-socket-error branch February 2, 2024 11:30
@alexander-akait
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Invalid WebSocket frame: RSV1 must be clear in Vue.js application with webpack-dev-server
2 participants