Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace :: with localhost before openBrowser() #4856

Merged

Conversation

chousheng
Copy link
Contributor

@chousheng chousheng commented May 9, 2023

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

test/server/open-option.test.js is modified.

Motivation / Use-Case

This PR resolves #4855. See #4855 for more details.

Breaking Changes

N/A

Additional Info

Below are the screencasts showing the fix on Windows and GitHub Codespaces.

Windows:

Before fix After fix
windows-before-fix.mov
windows-after-fix.mov

GitHub Codespaces:

Before fix After fix
codespaces-before-fix.mov
codespaces-after-fix.mov

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chousheng / name: Sheng Chou (ac971bd)

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 🎉

Comparison is base (4e35921) 91.72% compared to head (436bbd4) 91.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4856      +/-   ##
==========================================
+ Coverage   91.72%   91.85%   +0.12%     
==========================================
  Files          16       16              
  Lines        1704     1706       +2     
  Branches      647      649       +2     
==========================================
+ Hits         1563     1567       +4     
+ Misses        130      128       -2     
  Partials       11       11              
Impacted Files Coverage Δ
lib/Server.js 93.81% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chousheng chousheng force-pushed the fix-ipv6-unspecified-addr-open-browser branch from ac971bd to 436bbd4 Compare May 10, 2023 06:34
@chousheng
Copy link
Contributor Author

@alexander-akait, @snitin315. Thank you for reviewing!

Please let me know if I need to rebase the commit or do anything else before getting the PR merged.

@snitin315
Copy link
Member

We will merge this once CI is green.

@snitin315 snitin315 merged commit 874c44b into webpack:master May 12, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants