fix(client): add default fallback for client (#2015)

* fix(client): add default fallback for client

* test(server): update entry snapshot

* fix(client): move SockJSClient definition

* fix(client): update SockJSClient path resolution

* fix(client): add correct entry path

Author: knagaitsev

Diff for: client-src/default/socket.js

@@ -4,7 +4,19 @@
 /* eslint-disable
   camelcase
 */
-const Client = __webpack_dev_server_client__;
+
+// this SockJSClient is here as a default fallback, in case inline mode
+// is off or the client is not injected. This will be switched to
+// WebsocketClient when it becomes the default
+
+// important: the path to SockJSClient here is made to work in the 'client'
+// directory, but is updated via the webpack compilation when compiled from
+// the 'client-src' directory
+const Client =
+  typeof __webpack_dev_server_client__ !== 'undefined'
+    ? __webpack_dev_server_client__
+    : // eslint-disable-next-line import/no-unresolved
+      require('./clients/SockJSClient');
 
 let retries = 0;
 let client = null;

Diff for: client-src/default/webpack.config.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const webpack = require('webpack');
+
 module.exports = {
   mode: 'production',
   module: {
@@ -15,4 +17,12 @@ module.exports = {
       },
     ],
   },
+  plugins: [
+    new webpack.NormalModuleReplacementPlugin(/\/clients\//, (resource) => {
+      resource.request = resource.request.replace(
+        /\/clients\//,
+        '/../clients/'
+      );
+    }),
+  ],
 };

Diff for: client-src/live/webpack.config.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const path = require('path');
+const webpack = require('webpack');
 const CopyPlugin = require('copy-webpack-plugin');
 
 module.exports = {
@@ -33,5 +34,11 @@ module.exports = {
         to: path.resolve(__dirname, '../../client/live.html'),
       },
     ]),
+    new webpack.NormalModuleReplacementPlugin(/\/clients\//, (resource) => {
+      resource.request = resource.request.replace(
+        /\/clients\//,
+        '/../clients/'
+      );
+    }),
   ],
 };

Diff for: test/e2e/ClientOptions.test.js

@@ -166,7 +166,7 @@ describe('Client complex inline script path with sockPort', () => {
 });
 
 // previously, using sockPort without sockPath had the ability
-// to alter the sockPath (based on a bug in client-src/index.js)
+// to alter the sockPath (based on a bug in client-src/default/index.js)
 // so we need to make sure sockPath is not altered in this case
 describe('Client complex inline script path with sockPort, no sockPath', () => {
   beforeAll((done) => {