fix: avoid using eval in client (#5045)

webpack · Feb 13, 2024 · 7681477 · 7681477
1 parent 54abef7
commit 7681477
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 23 deletions.
diff --git a/client-src/modules/logger/SyncBailHookFake.js b/client-src/modules/logger/SyncBailHookFake.js
diff --git a/client-src/modules/logger/tapable.js b/client-src/modules/logger/tapable.js
@@ -0,0 +1,11 @@
+function SyncBailHook() {
+  return {
+    call() {},
+  };
+}
+
+/**
+ * Client stub for tapable SyncBailHook
+ */
+// eslint-disable-next-line import/prefer-default-export
+export { SyncBailHook };
diff --git a/client-src/webpack.config.js b/client-src/webpack.config.js
@@ -4,15 +4,12 @@ const path = require("path");
 const webpack = require("webpack");
 const { merge } = require("webpack-merge");
 
-// @ts-ignore
-const library = webpack.webpack
-  ? {
-      library: {
-        // type: "module",
-        type: "commonjs",
-      },
-    }
-  : { libraryTarget: "umd" };
+const library = {
+  library: {
+    // type: "module",
+    type: "commonjs",
+  },
+};
 
 const baseForModules = {
   devtool: false,
@@ -28,8 +25,7 @@ const baseForModules = {
   optimization: {
     minimize: false,
   },
-  // @ts-ignore
-  target: webpack.webpack ? ["web", "es5"] : "web",
+  target: ["web", "es5"],
   module: {
     rules: [
       {
@@ -73,8 +69,8 @@ module.exports = [
           '(typeof Symbol !== "undefined" ? Symbol : function (i) { return i; })',
       }),
       new webpack.NormalModuleReplacementPlugin(
-        /^tapable\/lib\/SyncBailHook/,
-        path.join(__dirname, "modules/logger/SyncBailHookFake.js"),
+        /^tapable$/,
+        path.join(__dirname, "modules/logger/tapable.js"),
       ),
     ],
   }),