Skip to content

Commit 0ae9be8

Browse files
hiroppyevilebottnawi
authored andcommittedMay 17, 2019
fix: add none and warning to clientLogLevel (#1901)
1 parent 45d39ac commit 0ae9be8

File tree

4 files changed

+37
-4
lines changed

4 files changed

+37
-4
lines changed
 

‎client-src/default/index.js

+13
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,12 @@ const DEBUG = 'debug';
6161
const TRACE = 'trace';
6262
const SILENT = 'silent';
6363

64+
// deprecated
65+
// TODO: remove these at major released
66+
// https://github.com/webpack/webpack-dev-server/pull/1825
67+
const WARNING = 'warning';
68+
const NONE = 'none';
69+
6470
// Set the default log level
6571
log.setDefaultLevel(INFO);
6672

@@ -121,6 +127,13 @@ const onSocketMsg = {
121127
case ERROR:
122128
log.setLevel(level);
123129
break;
130+
// deprecated
131+
case WARNING:
132+
// loglevel's warning name is different from webpack's
133+
log.setLevel('warn');
134+
break;
135+
// deprecated
136+
case NONE:
124137
case SILENT:
125138
log.disableAll();
126139
break;

‎lib/options.json

+10-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,16 @@
3737
]
3838
},
3939
"clientLogLevel": {
40-
"enum": ["info", "warn", "error", "debug", "trace", "silent"]
40+
"enum": [
41+
"info",
42+
"warn",
43+
"error",
44+
"debug",
45+
"trace",
46+
"silent",
47+
"none",
48+
"warning"
49+
]
4150
},
4251
"compress": {
4352
"type": "boolean"

‎test/__snapshots__/Routes.test.js.snap

+1-1
Large diffs are not rendered by default.

‎test/options.test.js

+13-2
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,19 @@ describe('options', () => {
120120
failure: [false],
121121
},
122122
clientLogLevel: {
123-
success: ['silent', 'info', 'error', 'warn', 'trace', 'debug'],
124-
failure: ['whoops!', 'none', 'warning'],
123+
success: [
124+
'silent',
125+
'info',
126+
'error',
127+
'warn',
128+
'trace',
129+
'debug',
130+
// deprecated
131+
'none',
132+
// deprecated
133+
'warning',
134+
],
135+
failure: ['whoops!'],
125136
},
126137
compress: {
127138
success: [true],

0 commit comments

Comments
 (0)
Please sign in to comment.