Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): methods should be string array #1550

Merged
merged 1 commit into from May 16, 2023
Merged

fix(types): methods should be string array #1550

merged 1 commit into from May 16, 2023

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented May 16, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9287c4) 96.82% compared to head (fc5b36a) 96.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1550   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files           9        9           
  Lines         378      378           
  Branches      115      115           
=======================================
  Hits          366      366           
  Misses         11       11           
  Partials        1        1           
Impacted Files Coverage Δ
src/index.js 97.91% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 41b2f77 into webpack:master May 16, 2023
17 checks passed
@alexander-akait
Copy link
Member

Thank you

@alexander-akait
Copy link
Member

Do you need release asap?

@JounQin JounQin deleted the fix/types_methods branch May 16, 2023 14:58
@JounQin
Copy link
Member Author

JounQin commented May 16, 2023

Do you need release asap?

I'm using @ts-expect-error temporarily, but sure if could be released soon. 🍺

@alexander-akait
Copy link
Member

@alexander-akait
Copy link
Member

Note - the latest version of webpack-dev-server still use v5, we are preparing a new major webpack-dev-server release, so I hope it will be soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants