Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): correct dev middleware context usage #1485

Merged

Conversation

MDAkramSiddiqui
Copy link
Contributor

@MDAkramSiddiqui MDAkramSiddiqui commented Mar 15, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

The usage of dev middleware context is mentioned incorrectly in documentation, currently its usage is defined as devMiddleware.context.stats whereas it should be devMiddleware.stats .

Breaking Changes

No breaking changes.

Additional Info

Fixes #1383

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MDAkramSiddiqui / name: Mohammad Akram (c50f783)

@snitin315
Copy link
Member

@MDAkramSiddiqui Can you accept CLA?

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2abef87) 97.34% compared to head (c50f783) 97.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files           9        9           
  Lines         377      377           
  Branches      112      112           
=======================================
  Hits          367      367           
  Misses          9        9           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MDAkramSiddiqui
Copy link
Contributor Author

done @snitin315

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@alexander-akait alexander-akait merged commit 032d90a into webpack:master Mar 15, 2023
@alexander-akait
Copy link
Member

Thank you

@MDAkramSiddiqui MDAkramSiddiqui deleted the mdakramsiddiqui-patch-1 branch March 16, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect stats position field in res object
3 participants