Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove cjs wrapper #1146

Merged
merged 3 commits into from Dec 16, 2021
Merged

feat: remove cjs wrapper #1146

merged 3 commits into from Dec 16, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

remove cjs wrapper

Breaking Changes

Potentially yes, but we use babel and out code in commonjs format, but typescript generates ESM, it is bug

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1146 (f2e4c17) into master (231cc46) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   97.27%   97.48%   +0.21%     
==========================================
  Files          10        9       -1     
  Lines         367      398      +31     
  Branches      123      123              
==========================================
+ Hits          357      388      +31     
  Misses          9        9              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 97.91% <100.00%> (+0.54%) ⬆️
src/middleware.js 95.83% <100.00%> (+0.32%) ⬆️
src/utils/getFilenameFromUrl.js 98.24% <100.00%> (+0.16%) ⬆️
src/utils/getPaths.js 100.00% <100.00%> (ø)
src/utils/ready.js 100.00% <100.00%> (ø)
src/utils/setupHooks.js 95.77% <100.00%> (+0.18%) ⬆️
src/utils/setupOutputFileSystem.js 100.00% <100.00%> (ø)
src/utils/setupWriteToDisk.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231cc46...f2e4c17. Read the comment docs.

@alexander-akait alexander-akait merged commit b6d53d3 into master Dec 16, 2021
@alexander-akait alexander-akait deleted the feat-remove-cjs-wrapper branch December 16, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant