Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positive watch warning #3783

Merged
merged 3 commits into from May 9, 2023
Merged

fix: false positive watch warning #3783

merged 3 commits into from May 9, 2023

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 9, 2023

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

No need

Summary

fixes #3778

Does this PR introduce a breaking change?

No, but now we just print a warning about using watch with dev server, but also we avoid extra loop, so our startup time will be faster

Other information

@alexander-akait alexander-akait requested a review from a team as a code owner May 9, 2023 05:57
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3783 (f72d885) into master (8027f71) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3783   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          22       22           
  Lines        1624     1624           
  Branches      463      462    -1     
=======================================
  Hits         1488     1488           
  Misses        136      136           
Impacted Files Coverage Δ
packages/serve/src/index.ts 79.46% <100.00%> (ø)
packages/webpack-cli/src/webpack-cli.ts 93.02% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8027f71...f72d885. Read the comment docs.

@alexander-akait alexander-akait merged commit c0436ba into master May 9, 2023
31 of 55 checks passed
@alexander-akait alexander-akait deleted the issue-3778 branch May 9, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect warning about watch command
2 participants