fix: fix path lookup & re-add infra docs (#480)

* fix: require validateSchema and optionsValidationError from webpack (#478)

* fix: fix lookups

Author: evenstensberg

bin/cli.js

@@ -16,16 +16,6 @@
 
 	require("v8-compile-cache");
 
-	// try local module, fallback to global
-	try {
-		require.resolve("webpack");
-		process.webpackModule = require("webpack");
-	} catch (err) {
-		const globalPathToWebpack = require("global-modules-path").getPath(
-			"webpack"
-		);
-		process.webpackModule = require(globalPathToWebpack);
-	}
 	const ErrorHelpers = require("./errorHelpers");
 
 	const NON_COMPILATION_ARGS = [
@@ -298,7 +288,7 @@ For more information, see https://webpack.js.org/api/cli/.`);
 			}
 
 			const firstOptions = [].concat(options)[0];
-			const statsPresetToOptions = process.webpackModule.Stats.presetToOptions;
+			const statsPresetToOptions = require("webpack").Stats.presetToOptions;
 
 			let outputOptions = options.stats;
 			if (
@@ -443,7 +433,7 @@ For more information, see https://webpack.js.org/api/cli/.`);
 				outputOptions.buildDelimiter = value;
 			});
 
-			const webpack = process.webpackModule;
+			const webpack = require("webpack");
 
 			let lastHash = null;
 			let compiler;
@@ -464,7 +454,7 @@ For more information, see https://webpack.js.org/api/cli/.`);
 			}
 
 			if (argv.progress) {
-				const ProgressPlugin = process.webpackModule.ProgressPlugin;
+				const ProgressPlugin = require("webpack").ProgressPlugin;
 				new ProgressPlugin({
 					profile: argv.profile
 				}).apply(compiler);

bin/convert-argv.js

@@ -4,9 +4,9 @@ fs.existsSync = fs.existsSync || path.existsSync;
 const interpret = require("interpret");
 const prepareOptions = require("./prepareOptions");
 const webpackConfigurationSchema = require("./webpackConfigurationSchema.json");
-const validateSchema = process.webpackModule.validateSchema;
-const WebpackOptionsValidationError =
-	process.webpackModule.WebpackOptionsValidationError;
+const validateSchema = require("webpack").validateSchema;
+const WebpackOptionsValidationError = require("webpack")
+	.WebpackOptionsValidationError;
 
 module.exports = function(...args) {
 	const argv = args[1] || args[0];
@@ -398,7 +398,7 @@ module.exports = function(...args) {
 				defineObject = {};
 			},
 			function() {
-				const DefinePlugin = process.webpackModule.DefinePlugin;
+				const DefinePlugin = require("webpack").DefinePlugin;
 				addPlugin(options, new DefinePlugin(defineObject));
 			}
 		);
@@ -468,13 +468,13 @@ module.exports = function(...args) {
 		mapArgToBoolean("cache");
 
 		ifBooleanArg("hot", function() {
-			const HotModuleReplacementPlugin =
-				process.webpackModule.HotModuleReplacementPlugin;
+			const HotModuleReplacementPlugin = require("webpack")
+				.HotModuleReplacementPlugin;
 			addPlugin(options, new HotModuleReplacementPlugin());
 		});
 
 		ifBooleanArg("debug", function() {
-			const LoaderOptionsPlugin = process.webpackModule.LoaderOptionsPlugin;
+			const LoaderOptionsPlugin = require("webpack").LoaderOptionsPlugin;
 			addPlugin(
 				options,
 				new LoaderOptionsPlugin({
@@ -510,8 +510,8 @@ module.exports = function(...args) {
 		});
 
 		ifArg("optimize-max-chunks", function(value) {
-			const LimitChunkCountPlugin =
-				process.webpackModule.optimize.LimitChunkCountPlugin;
+			const LimitChunkCountPlugin = require("webpack").optimize
+				.LimitChunkCountPlugin;
 			addPlugin(
 				options,
 				new LimitChunkCountPlugin({
@@ -521,8 +521,7 @@ module.exports = function(...args) {
 		});
 
 		ifArg("optimize-min-chunk-size", function(value) {
-			const MinChunkSizePlugin =
-				process.webpackModule.optimize.MinChunkSizePlugin;
+			const MinChunkSizePlugin = require("webpack").optimize.MinChunkSizePlugin;
 			addPlugin(
 				options,
 				new MinChunkSizePlugin({
@@ -532,7 +531,7 @@ module.exports = function(...args) {
 		});
 
 		ifBooleanArg("optimize-minimize", function() {
-			const LoaderOptionsPlugin = process.webpackModule.LoaderOptionsPlugin;
+			const LoaderOptionsPlugin = require("webpack").LoaderOptionsPlugin;
 			addPlugin(
 				options,
 				new LoaderOptionsPlugin({
@@ -542,7 +541,7 @@ module.exports = function(...args) {
 		});
 
 		ifArg("prefetch", function(request) {
-			const PrefetchPlugin = process.webpackModule.PrefetchPlugin;
+			const PrefetchPlugin = require("webpack").PrefetchPlugin;
 			addPlugin(options, new PrefetchPlugin(request));
 		});
 
@@ -555,7 +554,7 @@ module.exports = function(...args) {
 			} else {
 				name = value;
 			}
-			const ProvidePlugin = process.webpackModule.ProvidePlugin;
+			const ProvidePlugin = require("webpack").ProvidePlugin;
 			addPlugin(options, new ProvidePlugin(name, value));
 		});