Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip webpack-specific parts from filename #122

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Nov 29, 2022

This PR contains a:

Motivation / Use-Case

Use resourceQuery or resourceFragment with cache

Breaking Changes

Additional Info

It's hard to write tests for this case, the error is not from compilation.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ambar / name: ambar (6df5eac)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add test case?

@ambar
Copy link
Contributor Author

ambar commented Nov 29, 2022

@alexander-akait

It's hard to write tests for this case, the error is not from compilation (object).

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 92.75% // Head: 92.75% // No change to project coverage 👍

Coverage data is based on head (6df5eac) compared to base (fb08e81).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files           2        2           
  Lines          69       69           
  Branches       19       19           
=======================================
  Hits           64       64           
  Misses          5        5           
Impacted Files Coverage Δ
src/index.js 92.53% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

Tested, it works great 👍 thank you, it was my bad, I should look at an error reporting better, because of:

<w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: ENOENT: no such file or directory, lstat '/home/akait/IdeaProjects/val-loader-resource-query-bug1/val-entry.js?entry=foo'

@alexander-akait alexander-akait merged commit 41c08e3 into webpack-contrib:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants