Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node-sass v8 to release v10 branch #1101

Closed
pitgrap opened this issue Nov 15, 2022 · 6 comments · Fixed by #1103
Closed

Add support for node-sass v8 to release v10 branch #1101

pitgrap opened this issue Nov 15, 2022 · 6 comments · Fixed by #1103

Comments

@pitgrap
Copy link

pitgrap commented Nov 15, 2022

We're still relying on webpack4 and stuck to sass-loader v10. But we want to use node-sass v8 and node 18.

So please integrate #1100 into v10. Thank you.

@alexander-akait
Copy link
Member

Feel free to send a PR

@pitgrap
Copy link
Author

pitgrap commented Nov 15, 2022

You're too fast. ;) I was just finishing my fork and branch...

@alexander-akait
Copy link
Member

alexander-akait commented Nov 15, 2022

@pitgrap Yeah, I got the same request from other originizations and people, so I done it fast, released https://github.com/webpack-contrib/sass-loader/releases/tag/v10.4.0

@alexander-akait
Copy link
Member

I think we can close it

@pitgrap
Copy link
Author

pitgrap commented Nov 15, 2022

I think you missed this part in your PR: https://github.com/webpack-contrib/sass-loader/pull/1072/files

@alexander-akait
Copy link
Member

Good cathc, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants