Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot find module 'ts-node' #639

Merged
merged 1 commit into from Apr 3, 2023

Conversation

ntucker
Copy link
Contributor

@ntucker ntucker commented Apr 3, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Working with yarn or later npm versions, or pnp, etc. Anything not 5 years old package managers.

Additional Info

Fixes #636

Note: this will still be needed, even when https://github.com/Codex-/cosmiconfig-typescript-loader/issues/79 is resolved

cosmiconfig-typescript-loader peerDeps must be satisfied at any level it is included. Since it was added as a dependency, we must ensure they are specified so they can be resolved.

https://github.com/Codex-/cosmiconfig-typescript-loader/blob/main/package.json#LL39C6-L39C13 is the peerDeps

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2112904) 89.41% compared to head (37ac8b1) 89.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files           5        5           
  Lines         359      359           
  Branches      117      117           
=======================================
  Hits          321      321           
  Misses         35       35           
  Partials        3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit ab4d16a into webpack-contrib:master Apr 3, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'ts-node' (yarn)
2 participants