Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove result storage cache #78

Closed
wants to merge 2 commits into from

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Feb 5, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Resolve #74

Breaking Changes

Additional Info

@ricardogobbosouza ricardogobbosouza changed the title fix: remove resultStorage cache fix: remove result storage cache Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #78 (1b73671) into master (be0391e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          251       238   -13     
  Branches        71        70    -1     
=========================================
- Hits           251       238   -13     
Impacted Files Coverage Δ
src/linter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0391e...1b73671. Read the comment docs.

@ricardogobbosouza ricardogobbosouza deleted the fix-cache-result-storage branch February 6, 2021 20:08
@jsg2021
Copy link
Contributor

jsg2021 commented Feb 19, 2021

This cache is needed for the threaded mode... where results are computed on a per-file set basis on the worker pool...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module lint errors are reported when module is not included in webpack bundle
2 participants