Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output warning when built-in CSS support enabled #1520

Merged
merged 2 commits into from May 18, 2023

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 18, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

For better DX

Breaking Changes

No

Additional Info

part of webpack/webpack#17223, need to solve it for mini-css-extract-plugin and style-loader too

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (730f043) 96.81% compared to head (ff2b2a4) 96.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
+ Coverage   96.81%   96.84%   +0.02%     
==========================================
  Files          12       12              
  Lines        1131     1141      +10     
  Branches      411      418       +7     
==========================================
+ Hits         1095     1105      +10     
  Misses         27       27              
  Partials        9        9              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 0700ce8 into master May 18, 2023
20 checks passed
@alexander-akait alexander-akait deleted the fix-warning-for-future-built-in-css branch May 18, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant