Update README.md #147
Merged
Update README.md #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update actions/checkout to v3 and make it syntactically correct in order to allow copy and paste
|
Indeed a valuable observation and useful for improving DX (developer experience). Thank you! |
renovate bot
added a commit
to valora-inc/wallet
that referenced
this pull request
Aug 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webfactory/ssh-agent](https://togithub.com/webfactory/ssh-agent) | action | minor | `v0.5.3` -> `v0.8.0` | --- ### Release Notes <details> <summary>webfactory/ssh-agent (webfactory/ssh-agent)</summary> ### [`v0.8.0`](https://togithub.com/webfactory/ssh-agent/releases/tag/v0.8.0): SSH host keys no longer managed – read below 👇 [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.7.0...v0.8.0) Starting with this release, this action no longer writes GitHub's SSH host keys into the `known_hosts` SSH config file upon start. GitHub changed their host keys on short notice this morning, see https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. We took this as an opportunity to stop maintaining GH SSH keys in the code shipped with this action ([#​171](https://togithub.com/webfactory/ssh-agent/issues/171)). What you need to do: - On GitHub hosted runners, nothing. ✔︎ These runners ship with SSH host keys (for `github.com`) maintained by directly by GitHub. - On self-hosted runners, review and fix your SSH `known_hosts` file: - First, you'll find it bloated with redundant entries for `github.com`, as described in [#​106](https://togithub.com/webfactory/ssh-agent/issues/106). Remove these entries. - Review https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/. You probably removed the old (invalid) SSH key in the previous step. - Configure GitHub's current SSH keys as documented on https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints - As long as versions before `v0.8.0` of this action here are run on the self-hosted runner, the old entries will come back. Keep an eye on it, possibly you'll have to rinse & repeat. ##### Other code changes in this release - Update to `actions/checkout@v3` by [@​mpdude](https://togithub.com/mpdude) in [webfactory/ssh-agent#143 - Allow the user to override the commands for `git`, `ssh-agent`, and `ssh-add` by [@​DilumAluthge](https://togithub.com/DilumAluthge) in [webfactory/ssh-agent#154 ##### New Contributors - [@​prhiggins](https://togithub.com/prhiggins) made their first contribution in [webfactory/ssh-agent#153 - [@​kjarkur](https://togithub.com/kjarkur) made their first contribution in [webfactory/ssh-agent#147 - [@​DilumAluthge](https://togithub.com/DilumAluthge) made their first contribution in [webfactory/ssh-agent#154 **Full Changelog**: webfactory/ssh-agent@v0.7.0...v0.8.0 ### [`v0.7.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v070-2022-10-19) [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.6.0...v0.7.0) ##### Added - Add the `log-public-key` input that can be used to turn off logging key identities ([#​122](https://togithub.com/webfactory/ssh-agent/issues/122)) ##### Fixed - Fix path to `git` binary on Windows, assuming GitHub-hosted runners ([#​136](https://togithub.com/webfactory/ssh-agent/issues/136), [#​137](https://togithub.com/webfactory/ssh-agent/issues/137)) - Fix a nonsensical log message ([#​139](https://togithub.com/webfactory/ssh-agent/issues/139)) ### [`v0.6.0`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v060-2022-10-19) [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.5.4...v0.6.0) ##### Changed - Update the version of Node used by the action from 12 to 16 (https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). ### [`v0.5.4`](https://togithub.com/webfactory/ssh-agent/blob/HEAD/CHANGELOG.md#v054-2021-11-21) [Compare Source](https://togithub.com/webfactory/ssh-agent/compare/v0.5.3...v0.5.4) ##### Fixed - Update changed GitHub Host Keys ([#​102](https://togithub.com/webfactory/ssh-agent/issues/102), [#​101](https://togithub.com/webfactory/ssh-agent/issues/101)) ##### Changed - Various documentation (README) improvements and additions - Change logging to more precisely state that *public* keys are being printed </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update actions/checkout to v3 and make it syntactically correct in order to allow copy and paste