Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: New version of got breaks backwards compatibility #11793

Closed
1 task done
nspector opened this issue Dec 5, 2023 · 2 comments
Closed
1 task done

[🐛 Bug]: New version of got breaks backwards compatibility #11793

nspector opened this issue Dec 5, 2023 · 2 comments
Assignees
Labels

Comments

@nspector
Copy link

nspector commented Dec 5, 2023

Have you read the Contributing Guidelines on issues?

WebdriverIO Version

8.24.9

Node.js Version

node 18

Mode

Standalone Mode

Which capabilities are you using?

No response

What happened?

With the change here - #11790. got was upgraded from 12 to 14 (sindresorhus/got#2313). In got version 14, it changed it's node engine support. This was a major version change for got but not a major version change for webdriver. This should be a major version change for webdriver if dependencies are now going to change node engine requirements

What is your expected behavior?

Installs continue to work without needing to change node version

How to reproduce the bug.

Have node 18 installed, do an npm i of newest webdriver

Relevant log output

npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: got@14.0.0
npm ERR! notsup Not compatible with your version of node/npm: got@14.0.0
npm ERR! notsup Required: {"node":">=20"}
npm ERR! notsup Actual:   {"npm":"9.5.0","node":"v18.15.0"}


### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

### Is there an existing issue for this?

- [X] I have searched the existing issues
@nspector nspector added Bug 🐛 Needs Triaging ⏳ No one has looked into the issue yet labels Dec 5, 2023
@christian-bromann
Copy link
Member

@nspector sorry about that, we already pushed a fix and release as soon as possible.

@christian-bromann christian-bromann removed the Needs Triaging ⏳ No one has looked into the issue yet label Dec 5, 2023
@christian-bromann christian-bromann self-assigned this Dec 5, 2023
@christian-bromann
Copy link
Member

christian-bromann commented Dec 5, 2023

A fix is pushed and released in v8.24.12. Sorry again for the inconvenience, we made sure to not update got again until v9 is released.

colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Dec 6, 2023
Prevents Dependabot PRs from completing `npm ci` when package updates require Node.js > v16 etc

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Dec 6, 2023
…son field

Prevents Dependabot PRs from completing `npm ci` when package updates require Node.js > v16 etc

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Dec 12, 2023
Prevents Dependabot PRs from completing the Tests workflow when package updates require Node.js > v16 etc

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Dec 12, 2023
Prevents Dependabot PRs from completing the Tests workflow when package updates require Node.js > v16 etc

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Apr 4, 2024
Prevents Dependabot PRs from completing the Tests workflow when package updates require incompatible Node.js versions

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Apr 4, 2024
Prevents Dependabot PRs from completing the Tests workflow when package updates require incompatible Node.js versions

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Apr 5, 2024
Prevents Dependabot PRs from completing the Tests workflow when package updates require incompatible Node.js versions

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Apr 8, 2024
Prevents Dependabot PRs from completing the Tests workflow when package updates require incompatible Node.js versions

See webdriverio#11793
colinrotherham added a commit to colinrotherham/webdriverio that referenced this issue Apr 8, 2024
Prevents Dependabot PRs from completing the Tests workflow when package updates require incompatible Node.js versions

See webdriverio#11793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants