Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-providers-ws install issue in Windows #2999

Closed
EthyMoney opened this issue Aug 4, 2019 · 2 comments
Closed

web3-providers-ws install issue in Windows #2999

EthyMoney opened this issue Aug 4, 2019 · 2 comments

Comments

@EthyMoney
Copy link

EthyMoney commented Aug 4, 2019

Description

Installing web3 module in Windows environment fails at install script for web3-providers-ws due to a remove command issue.

Expected behavior

del should be used when executing remove commands in Windows.

Actual behavior

rm is being used to remove in Windows.

Steps to reproduce the behavior

Install web3 npm module normally while in Windows environment.

Error Logs

npm ERR! errno 1
npm ERR! web3-providers-ws@1.2.0 preinstall: `rm -rf node_modules/websocket/.git`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the web3-providers-ws@1.2.0 preinstall script.

Versions

  • web3.js: 1.2.0
  • nodejs: 12.7.0
  • npm: 6.10.2
  • environment: Windows 10 pro x64 build 1903
@deamme
Copy link

deamme commented Aug 4, 2019

Same issue here.. It should be using https://github.com/isaacs/rimraf if possible

@nivida
Copy link
Contributor

nivida commented Aug 4, 2019

duplication of #2971 and will be released with 1.2.1

@nivida nivida closed this as completed Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants