Suggest-a-spec #709
Merged
Suggest-a-spec #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am often forgetting to set the level for CSS specs. This does an OK job of suggesting something better in those cases. We might extend this further to catch typos and the like.
foolip
approved these changes
Mar 23, 2024
| * Print an array of potential spec URLs. | ||
| */ | ||
| function suggestSpecs(bad: URL): void { | ||
| const searchBy = bad.pathname.replaceAll("/", ""); |
There was a problem hiding this comment.
This won't work very well for a case like https://www.ietf.org/archive/id/draft-zern-webp-13.html where searchBy becomes "archiveiddraft-zern-webp-13.html", but it will certainly do the trick for the common case of not knowing which number to put after the dash in CSS specs.
We can improve this further if there's another category of bad spec URLs that keeps coming up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am often forgetting to set the level for CSS specs. This does an OK job of suggesting something better in those cases. We might extend this further to catch typos and the like.