Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaviate Agents extras integration #1562

Merged
merged 6 commits into from
Feb 28, 2025
Merged

Conversation

cdpierse
Copy link
Contributor

@cdpierse cdpierse commented Feb 20, 2025

  • Adds weaviate_agents package as an optional extra.
  • Add type stub files (.pyi) for the agents module to provide proper type hints for the optional weaviate-agents functionality. These stubs maintain type information while gracefully handling cases where the weaviate-agents package is not installed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (efd9955) to head (b1455d4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/exceptions.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   88.25%   88.36%   +0.10%     
==========================================
  Files         186      186              
  Lines       15875    15882       +7     
==========================================
+ Hits        14011    14034      +23     
+ Misses       1864     1848      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdpierse cdpierse changed the title Weaviate Agents Extras Integration Weaviate Agents extras integration Feb 20, 2025
@@ -0,0 +1,6 @@
from weaviate.exceptions import WeaviateAgentsNotInstalledError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need these .pyi files in addition to the .py file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the .pyi stubs give us the ability to provide type hints for the optional package functionality when required by giving the type checkers the right hints but because they are not real __init__.py files the none of the paths will work at runtime if extras is not installed.

@cdpierse cdpierse marked this pull request as ready for review February 21, 2025 11:05
@dirkkul dirkkul merged commit 8a482fe into main Feb 28, 2025
45 checks passed
@dirkkul dirkkul deleted the weaviate-agents-integration branch February 28, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants