-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaviate Agents extras integration #1562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
![]() |
Infrastructure as Code | ![]() ![]() ![]() ![]() |
View in Orca |
![]() |
SAST | ![]() ![]() ![]() ![]() |
View in Orca |
![]() |
Secrets | ![]() ![]() ![]() ![]() |
View in Orca |
![]() |
Vulnerabilities | ![]() ![]() ![]() ![]() |
View in Orca |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 88.25% 88.36% +0.10%
==========================================
Files 186 186
Lines 15875 15882 +7
==========================================
+ Hits 14011 14034 +23
+ Misses 1864 1848 -16 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,6 @@ | |||
from weaviate.exceptions import WeaviateAgentsNotInstalledError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need these .pyi files in addition to the .py file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the .pyi
stubs give us the ability to provide type hints for the optional package functionality when required by giving the type checkers the right hints but because they are not real __init__.py
files the none of the paths will work at runtime if extras is not installed.
weaviate_agents
package as an optional extra.