Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure datetimepicker widget overlay shows over modals & drop-downs #10266

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

lb-
Copy link
Member

@lb- lb- commented Mar 25, 2023

Before

Screenshot 2023-03-25 at 9 16 11 pm

Screenshot 2023-03-25 at 9 15 46 pm

Note: I have toggled the datetime picker to show manually to make the problem more visible (dropdown AND datetimepicker shown at the same time.

After

Screenshot 2023-03-25 at 9 12 20 pm

Screenshot 2023-03-25 at 9 14 22 pm

Screenshot 2023-03-25 at 9 22 12 pm

- Update to the exact same z-index as the modal
- Fixes wagtail#3604
@squash-labs
Copy link

squash-labs bot commented Mar 25, 2023

Manage this branch in Squash

Test this branch here: https://lb-fix3604-datetimepicker-z-in-tjs1z.squash.io

@lb-
Copy link
Member Author

lb- commented Mar 25, 2023

Might be worth back-porting this fix to current LTS and maybe also 4.2 if merged.

@gasman gasman added this to the 4.2.2 milestone Mar 25, 2023
@lb- lb- changed the title Ensure datetimepicker widget overlay shows over modals Ensure datetimepicker widget overlay shows over modals & drop-downs Mar 26, 2023
@gasman gasman merged commit 1532eed into wagtail:main Apr 1, 2023
gasman added a commit that referenced this pull request Apr 1, 2023
gasman added a commit that referenced this pull request Apr 1, 2023
gasman added a commit that referenced this pull request Apr 1, 2023
gasman added a commit that referenced this pull request Apr 1, 2023
gasman added a commit that referenced this pull request Apr 1, 2023
@lb- lb- deleted the fix/3604-datetimepicker-z-index branch April 1, 2023 04:34
@lb-
Copy link
Member Author

lb- commented Apr 1, 2023

Thanks Matt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong z-index of date/time/datetime pickers
2 participants