Adds support for posinset/setsize in toolbars #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smhigley
reviewed
Apr 29, 2024
index.html
Outdated
| @@ -9367,6 +9406,7 @@ <h5>Presentational Role Inheritance</h5> | |||
| <p>The toolbar is often a subset of functions found in a <rref>menubar</rref>, designed to reduce user effort in using these functions. Authors MUST supply a label on each toolbar when the application contains more than one toolbar.</p> | |||
| <p>Authors MAY manage focus of descendants for all instances of this <a>role</a>, as described in <a href="#managingfocus">Managing Focus</a>.</p> | |||
| <p>Elements with the role <code>toolbar</code> have an implicit <pref>aria-orientation</pref> value of <code>horizontal</code>.</p> | |||
| <p>Authors MAY set <pref>aria-setsize</pref> and <a>aria-posinset</a> on focusable interactive <a>accessibility children</a> of the role <code>toolbar</code> that don't have a <a href="#scope">required accessibility parent role</a>. Authors MUST NOT set <pref>aria-setsize</pref> and <a>aria-posinset</a> values scoped to the <code>toolbar</code> on <a href="#mustContain">allowed accessibility child roles</a> of any <rref>composite</rref> <rref>widget</rref> that already provides indexing.</p> | |||
There was a problem hiding this comment.
Couple small thoughts:
- I think it'd be good to add another paragraph stating that, unlike other composite widgets supporting these attributes, browsers do not provide implicit values for
aria-setsizeandaria-posinsetwithin toolbars. - I'd actually suggest removing the "that don't have a required accessibility parent role" text from the first sentence. If you use the same "accessibility children or accessibility descendants with only groups intervening" language from elsewhere, then that already rules out controls that have their own other composite widget parent.
- I might also suggest softening the "Authors MUST NOT" sentence, since I can kinda see a case where (chthulu help us) someone puts an inline menu inside a toolbar, but wants to keep the indexing flat for all controls within the toolbar. Maybe not a wonderful idea, but I'm not sure it merits a must-level spec requirement. How about something like this? "If the toolbar contains controls that already support aria-posinset and aria-setsize (such as options in a listbox or menuitems in a menu), authors SHOULD treat any provided aria-posinset and aria-setsize values on those descendants as fully independent from the toolbar scope."
I'm consolidating those into a change suggestion for ease of reviewing, but don't feel any pressure to use my wording 😅
Suggested change
| <p>Authors MAY set <pref>aria-setsize</pref> and <a>aria-posinset</a> on focusable interactive <a>accessibility children</a> of the role <code>toolbar</code> that don't have a <a href="#scope">required accessibility parent role</a>. Authors MUST NOT set <pref>aria-setsize</pref> and <a>aria-posinset</a> values scoped to the <code>toolbar</code> on <a href="#mustContain">allowed accessibility child roles</a> of any <rref>composite</rref> <rref>widget</rref> that already provides indexing.</p> | |
| <p>Authors MAY set <pref>aria-setsize</pref> and <pref>aria-posinset</pref> on focusable interactive <a>accessibility children</a> of the role <code>toolbar</code> or <a>accessibility descendants</a> with only elements with role <rref>group</rref> intervening. If the <code>toolbar</code> contains controls that already support <pref>aria-posinset</pref> and <pref>aria-setsize</pref> (such as <rref>option</rref> in a <rref>listbox</rref> or <rref>menuitem</rref> in a <rref>menu</rref>), authors SHOULD treat any provided <pref>aria-posinset</pref> and <pref>aria-setsize</pref> values on those descendants as fully independent from the toolbar scope.</p> | |
| <p>Unlike other roles that support <pref>aria-setsize</pref> and <pref>aria-posinset</pref> such as <rref>listitem</rref> or <rref>menuitem</rref>, browsers are not required to calculate implicit values scoped to a <code>toolbar</code>.</p> |
There was a problem hiding this comment.
@smhigley This is listed as outdated but still showing up instead of collapsed. Given my lack of GitHub skills, what does this mean and how can I resolve it?
smhigley
reviewed
May 2, 2024
Corrects "accessibility children" to "accessibility descendants" Co-authored-by: Sarah Higley <smhigley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2158
Outlines which roles within
toolbarcan acceptaria-setsizeandaria-posinset.PR tracking
Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.
Test, Documentation and Implementation tracking
Once this PR and all related PRs have been approved by the working group, tests
should be written and issues should be opened on browsers. Add N/A and check when not
applicable.
Preview | Diff