Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix the role attribute definition. #2146

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Mar 11, 2024

Fixes #2145


Preview | Diff

@jnurthen jnurthen requested a review from pkra March 12, 2024 22:15
@pkra
Copy link
Member

pkra commented Mar 14, 2024

@jnurthen what about this comment in the linked issue

This paragraph claims that "An implementing host language will provide a role attribute", but HTML does not in fact provide one

Do you want to change that line in Section 8.1 to avoid confusion?

@@ -450,7 +446,7 @@ <h1>Using <abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr></h
<p>Authors need to associate [=elements=] in the document to a WAI-ARIA role and the appropriate states and properties (aria-* [=attributes=]) during its life-cycle, unless the elements already have the appropriate <a href="#implicit_semantics">implicit WAI-ARIA semantics</a> for states and properties. In these instances the equivalent host language states and properties take precedence to avoid a conflict while the role attribute will take precedence over the implicit role of the host language element.</p>
<section id="introroles" class="normative">
<h2><abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr> Roles</h2>
<p>A <abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr> <a>role</a> is set on an <a>element</a> using a <code>role</code> <a>attribute</a>, similar to the <code>role</code> attribute defined in <cite><a href="https://www.w3.org/TR/role-attribute/">Role Attribute</a></cite> [[ROLE-ATTRIBUTE]].</p>
<p>A <abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr> <a>role</a> is set on an <a>element</a> using a <code><dfn id="attr-role" data-dfn-type="element-attr">role</dfn></code> <a>attribute</a>, similar to the <code>role</code> attribute defined in <cite><a href="https://www.w3.org/TR/role-attribute/">Role Attribute</a></cite> [[ROLE-ATTRIBUTE]].</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the dfn need class="export"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the role attribute definition.
2 participants