Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insertions and deletions in PR diff preview are unreadable in dark mode #2133

Open
adampage opened this issue Feb 29, 2024 · 1 comment · May be fixed by #2138
Open

Insertions and deletions in PR diff preview are unreadable in dark mode #2133

adampage opened this issue Feb 29, 2024 · 1 comment · May be fixed by #2138
Assignees
@pkra @daniel-montalvo
Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Comments

@adampage
Copy link
Member

adampage commented Feb 29, 2024 •
edited

I’m not sure this is the proper home for this issue, but I just noticed that the color styles for the ins and del elements in our PR diff previews make their text unreadable if your OS environment is in dark mode.

A video capture demonstrating how the colors for ins and del elements in htmldiff’d W3C documents become unreadable in dark mode

I tracked this back to issue w3c/htmldiff-ui#12, where @tabatkins says:

...The answer is to make your documents darkmode-aware...

Is that something we can/should do for our documents?
@adampage adampage added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Feb 29, 2024
@daniel-montalvo
Copy link
Contributor

@adampage
Thanks for bringing this to our attention

Hopefully this is soon addressed in respec
Ref:
w3c/respec#2651

@daniel-montalvo daniel-montalvo mentioned this issue Feb 29, 2024
Closed
@daniel-montalvo daniel-montalvo linked a pull request Mar 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkra pkra

@daniel-montalvo daniel-montalvo

Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Draft] Enables respec darkmode w3c/aria
3 participants
@pkra @adampage @daniel-montalvo