fix(onClickOutside): adjust shouldListen handling timing #3503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if the target is falsy, we should care about the ignore options
fix #3465
Before submitting the PR, please make sure you do the following
fixes #123
).Description
In current logic, if the target is falsy when the event trigger, it won't care about the ignore options which make no sense.
This PR change the logic to judge if should ignore at first before any other judgements related with e
Additional context
🤖 Generated by Copilot at 018e21c
Refactor and optimize the
onClickOutside
function inpackages/core/onClickOutside/index.ts
by simplifying and reordering the logic for setting theshouldListen
variable.🤖 Generated by Copilot at 018e21c
shouldListen
(link)