-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useChangeCase)!: migrate to change-case@v5
, closes #3457
#3460
Merged
+65
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change-case@v5
closes #3457
change-case@v5
closes #3457change-case@v5
, closes #3457
change-case@v5
, closes #3457change-case@v5
, closes #3457
Any change this will be merged soon? |
change-case@v5
, closes #3457change-case@v5
, closes #3457
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Running into this too. useChangeCase is broken. |
bumping this |
antfu
approved these changes
Jun 12, 2024
change-case@v5
, closes #3457change-case@v5
, closes #3457
This was referenced Sep 7, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BREAKING CHNAGE
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
Closes #3457
I've updated the function so we are no longer explicitly importing the change case functions. This should hopefully help future proof the function to any changes in naming made on their end. Also updated to parameters to allow refs and getters.
🤖 Generated by Copilot at 0473413
Refactored and improved the
useChangeCase
hook and demo. The hook now uses thechange-case
library and accepts reactive arguments. The demo is more concise and uses the library directly. ThechangeCase.ts
file was removed as it was no longer needed.🤖 Generated by Copilot at 0473413
useChangeCase
hook to usechange-case
library directly (link, link, link, link)changeCase.ts
file (link)ChangeCaseType
type from library's exported keys (link)changeCaseTransforms
object to map case names to functions (link)toValue
helper to handle reactivetype
andoptions
arguments (link)transforms
array dynamically from library's functions indemo.vue
(link)demo.vue
(link)demo.vue
(link)