fix(build): ensure correct typing for node esm #3209
Merged
+35
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
According to https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
the only way to correct provide types for both Node ESM and CJS is to have two separate declaration files, so we need to generate
.d.mts
and.d.cts
upon build.Additional context
see vuejs/core@d621d4c
🤖 Generated by Copilot at 0986352
This pull request improves the type definition support for the
vueuse
packages and components, especially for the Vue 3 script setup and module script syntax. It fixes or removes thetypes
andexports
fields in thepackage.json
files of each package to avoid conflicts or errors with TypeScript and bundlers. It also generates different type definition files (.d.cts
and.d.mts
) for each syntax and re-exports them from thecore
package. It updates the build and fix scripts to handle the new type definition files.🤖 Generated by Copilot at 0986352
.d.cts
and.d.mts
files for type definitions instead of.d.ts
files to support script setup and module script syntax (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)metadata
package incore
package to avoid importing.d.ts
files (link, link).d.cts
and.d.mts
files locally inbuild.ts
script (link).d.cts
and.d.mts
files infix-types.ts
script (link)