Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][master branch] Possible bug where string values are passed as transition hooks #19617

Closed
yyx990803 opened this issue Apr 15, 2024 · 2 comments
Assignees
Labels
S: triage upstream Problem with a third party library that we may have to work around

Comments

@yyx990803
Copy link
Contributor

Environment

Vuetify Version: latest master
Vue Version: latest main (soon to be released 3.4.22)
Browsers: Chrome 123.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

This is discovered in Vue core ecosystem-ci after merging vuejs/core#8953

See linked ecosystem-ci log for the test cases affected.

Expected Behavior

No string values passed to onBeforeEnter hook

Actual Behavior

String values are passed to onBeforeEnter hook

Reproduction Link

https://github.com/vuejs/ecosystem-ci/actions/runs/8692149431/job/23836077334

@KaelWD KaelWD self-assigned this Apr 15, 2024
@KaelWD
Copy link
Member

KaelWD commented Apr 15, 2024

We're passing functions not strings, this is a transition-group-stub from vue-test-utils.

return h(tag as FunctionalComponent, {
name: props.disabled ? '' : name,
css: !props.disabled,
...(props.group ? undefined : { mode: props.mode }),
...(props.disabled ? {} : functions),
}, slots.default)

@alecgibson
Copy link

I've opened vuejs/test-utils#2411

@KaelWD KaelWD closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
@KaelWD KaelWD added the upstream Problem with a third party library that we may have to work around label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: triage upstream Problem with a third party library that we may have to work around
Projects
None yet
Development

No branches or pull requests

3 participants