Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTable): bgColor when using the sticky prop #18993

Conversation

websitevirtuoso
Copy link
Contributor

Fixes #18984

Description

Markup:

@johnleider johnleider added this to the v3.4.x milestone Jan 8, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VDataTable labels Jan 8, 2024
@johnleider johnleider changed the base branch from dev to master January 8, 2024 15:06
@johnleider johnleider changed the base branch from master to dev January 8, 2024 15:06
@johnleider johnleider force-pushed the fix/v-data-table-sticky-header-color branch from d95c7ba to 65fb9d4 Compare January 8, 2024 15:22
@johnleider johnleider changed the base branch from dev to master January 8, 2024 15:22
@johnleider johnleider merged commit 0112c7f into vuetifyjs:master Jan 8, 2024
6 of 7 checks passed
@johnleider johnleider changed the title fix(VDataTable): sticky header problem with bgColor fix(VDataTable): bgColor when using the sticky prop Jan 8, 2024
@websitevirtuoso websitevirtuoso deleted the fix/v-data-table-sticky-header-color branch January 8, 2024 18:18
@SveinnB
Copy link

SveinnB commented Jan 9, 2024

@websitevirtuoso thank you for this PR 👍🏻
But I have one problem
See https://play.vuetifyjs.com/#...

@websitevirtuoso
Copy link
Contributor Author

Yes I see. It has to be new prop to set bgColor for header.

@websitevirtuoso
Copy link
Contributor Author

websitevirtuoso commented Jan 10, 2024

What about option to set prop header
and for each item set class

image

@websitevirtuoso
Copy link
Contributor Author

Created new PR with option to control color via props
ex:
image

johnleider added a commit that referenced this pull request Jan 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fixes #18993

Co-authored-by: John Leider <john@vuetifyjs.com>
tmasrat pushed a commit to tmasrat/vuetify that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.9] v-data-table sticky header collide with data
3 participants