Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.4.7] VDataTable prevIcon, nextIcon dont work #18893

Closed
bq-t opened this issue Dec 17, 2023 · 0 comments · Fixed by #18909
Closed

[Bug Report][3.4.7] VDataTable prevIcon, nextIcon dont work #18893

bq-t opened this issue Dec 17, 2023 · 0 comments · Fixed by #18909
Assignees
@johnleider
Labels
C: VDataTable T: bug Functionality that does not work as intended/expected
Milestone
v3.4.x

Comments

@bq-t
Copy link

bq-t commented Dec 17, 2023

Environment

Vuetify Version: 3.4.7
Vue Version: 3.3.12
Browsers: Chrome 120.0.0.0
OS: Windows 10

Steps to reproduce

Create VDataTable, set up props for paginate icons: prevIcon, nextIcon, firstIcon, lastIcon.

Expected Behavior

The icons have changed

Actual Behavior

Icons don't change

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

I checked the source code and probably the props are simply not passed into the next component
@SonTT19 SonTT19 mentioned this issue Dec 20, 2023
Merged
@johnleider johnleider self-assigned this Jan 8, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VDataTable and removed S: triage labels Jan 8, 2024
@johnleider johnleider added this to the v3.4.x milestone Jan 8, 2024
johnleider pushed a commit that referenced this issue Jan 8, 2024
@SonTT19
fix(VDataTableFooter): filter VPaginate props (#18909)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
60b2abd 
fixes #18893
tmasrat pushed a commit to tmasrat/vuetify that referenced this issue Jan 22, 2024
@SonTT19 @tmasrat
fix(VDataTableFooter): filter VPaginate props (vuetifyjs#18909)
f91a504 
fixes vuetifyjs#18893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VDataTable T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.4.x
Development

Successfully merging a pull request may close this issue.

fix(VDataTableFooter): filter VPaginate props SonTT19/vuetify
2 participants
@johnleider @bq-t