Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.3.0] Unable to override sass VInput variables #17419

Closed
stevenhurth opened this issue May 21, 2023 · 9 comments
Closed

[Bug Report][3.3.0] Unable to override sass VInput variables #17419

stevenhurth opened this issue May 21, 2023 · 9 comments
Assignees
Labels
C: VField sass T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone

Comments

@stevenhurth
Copy link

After upgrading to 3.3.0, we are no longer able to override VInput variables in our custom settings. ONLY VInput variables (all of them) throw this error when we try to override them, every other component variable works just fine.

“This variable was not declared with !default in the @used module.”

Checking the source for 3.3.0, the input variables are indeed declared with !default though.

nuxt 3.5
Vite
Sass 1.62.1

@stevenhurth stevenhurth changed the title 3.3.0 - Unable to override sass VInput variables [Bug Report][3.3.0] Unable to override sass VInput variables May 21, 2023
@lioneaglesolutions lioneaglesolutions added T: bug Functionality that does not work as intended/expected sass and removed S: triage labels May 22, 2023
@lioneaglesolutions
Copy link
Collaborator

lioneaglesolutions commented May 22, 2023

@johnleider can confirm this is a bug (not just with Nuxt) - facing the issue myself. Seems this could be somewhat breaking?

@johnleider
Copy link
Member

johnleider commented May 22, 2023

You've submitted an issue that does not contain a valid or simple reproduction. In order to effectively disposition this, we need to verify that the problem exists outside of your environment as concisely as possible. This issue will be tagged as needs reproduction for the next 48 hours before being closed.

You can find information on how to contribute to Vuetify below:

Keep in mind we cannot debug a personal application. Thank you for your understanding. If you have any questions, please reach out to us in our Discord community.

@johnleider johnleider added the S: needs reproduction The issue does not contain a valid reproduction label May 22, 2023
@lioneaglesolutions
Copy link
Collaborator

@KaelWD KaelWD added T: regression Something that used to work but we broke C: VField and removed S: needs reproduction The issue does not contain a valid reproduction labels May 22, 2023
@KaelWD KaelWD added this to the v3.3.x milestone May 22, 2023
@KaelWD KaelWD self-assigned this May 22, 2023
@KaelWD
Copy link
Member

KaelWD commented May 22, 2023

This breaks it:

@use '../VInput/variables' as *;

@lioneaglesolutions
Copy link
Collaborator

@KaelWD I'd be interested in an explanation as to why this breaks it if you get a chance

@KaelWD KaelWD closed this as completed in 75e0472 May 22, 2023
@KaelWD
Copy link
Member

KaelWD commented May 22, 2023

with is only inherited if the module is forwarded before being used

@SergkeiM
Copy link

After fix for me stayed the same with error:
image

I guess I will need now to re-work how I @forward "vuetify/settings"

@KaelWD
Copy link
Member

KaelWD commented May 24, 2023

https://github.com/lioneaglesolutions/vuetify-issue-17419 works for me with 3.3.1

@stevenhurth
Copy link
Author

I can confirm this fixed the issue for us. Thank you kindly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VField sass T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

No branches or pull requests

5 participants