Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): optimizing css variable acquisition #1322

Conversation

zhaopan-pan
Copy link
Contributor

optimize the acquisition method of css variables and encapsulate related methods

Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation! Suggested some minor changes

ecosystem/theme-default/src/client/shim.d.ts Outdated Show resolved Hide resolved
@meteorlxy
Copy link
Member

@zhaopan-pan added 2 more comments

@zhaopan-pan
Copy link
Contributor Author

@zhaopan-pan added 2 more comments

i has optimized it

@meteorlxy meteorlxy merged commit eb0d0ea into vuepress:main May 10, 2023
29 checks passed
@meteorlxy
Copy link
Member

Thanks for your contributions! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants