Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update deps, drop node14 #1311

Merged
merged 7 commits into from May 11, 2023
Merged

feat!: update deps, drop node14 #1311

merged 7 commits into from May 11, 2023

Conversation

Mister-Hope
Copy link
Member

No description provided.

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Apr 20, 2023

This PR contains:

  • bump all non major deps

@meteorlxy
Copy link
Member

Let's postpone until node 14 EOL

@Mister-Hope Mister-Hope changed the title feat!: update deps, drop Node14 chore: update deps Apr 21, 2023
@Mister-Hope

This comment was marked as outdated.

@Mister-Hope Mister-Hope changed the title chore: update deps feat!: update deps, drop node14 May 8, 2023
@Mister-Hope
Copy link
Member Author

Mister-Hope commented May 8, 2023

Some updates, it works fine here, but the solution is not working downstream in my repo.

When we set manualChunks option with file path based modules, vite@4.3 totally stop spliting chunks according to import() when the imported package has deps that is "chunk spliting" manually with the option.

An example is @vue/repl that vuepress-plugin-md-enhance is using. Since we are adding tree-shaking support for this module, the plugin is generating a file at temp folder and use it as clientConfig file, so that @vue/repl would not be imported and analyzed if user does not enable vue playground feature.

The official vue playground has vue and vue/complier(or @vue/compiler-sfc) as deps, while I delete all related code inside manualChunks, the import('@vue/repl') can result a assets/vue-repl-[hash].js chunk which is 4.3Mb large.

However, if we manually set any related deps that @vue/repl needs (e.g.: vue, @vue/shared), the chunk is no longer generated, instead it appears in app,[hash].js entry file.

@meteorlxy Any suggestions here?

@meteorlxy
Copy link
Member

@Mister-Hope I'd suggest to revert vite to 4.2 in the PR. Let's do other deps' updates and node version bump first. Then upgrade vite to 4.3 in another PR

@meteorlxy meteorlxy merged commit a8c30ee into main May 11, 2023
29 checks passed
@meteorlxy meteorlxy deleted the deps branch May 11, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants