Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] resolveRoute does not support relative path #1492

Closed
Mister-Hope opened this issue Feb 6, 2024 · 2 comments
Closed

[Bug report] resolveRoute does not support relative path #1492

Mister-Hope opened this issue Feb 6, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request package:client

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 6, 2024

Description

resolveRoute should support relative path, just like router.resolve()

E.g.:

// at /page/a.html
resolve('b.html') // should be /page/b.html
resolve('../') // should be /

Why this is needed

prev and next links are based on current route path, as people just set relative links like ./a.md and ../

Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@github-actions github-actions bot added the stale label Feb 22, 2024
@Mister-Hope Mister-Hope added bug Something isn't working package:client and removed stale labels Feb 22, 2024
@meteorlxy meteorlxy added enhancement New feature or request and removed bug Something isn't working labels Feb 25, 2024
@Mister-Hope Mister-Hope linked a pull request Apr 6, 2024 that will close this issue
@Mister-Hope Mister-Hope assigned Mister-Hope and unassigned meteorlxy Apr 6, 2024
@meteorlxy
Copy link
Member

Closed by #1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package:client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants