[Bug report] The header anchor should stay outside of the heading tag

[Vasile-Peste]

Description

The header anchors # are placed inside the heading tags (h1, h2, h3...).
This behaviour is not actually correct, since the heading tag should explicitly indicate the nature of the content as a title, and # shouldn't be part of it.

Apart from the semantic issue, there is also a more problematic issue: crawlers, some social media crawlers may take the title from the h1 heading tag to create a post preview. This means that the preview title of the post will contain the "#" character.

This is an example of a VuePress post preview on LinkedIn

To reproduce I have a live link
https://www.mida.org/posts/reactive-programming-in-financial-markets/

The website above is built with VuePress 1 but the issue persists also on VuePress 2.

Thank you,
Vasile

Reproduction

https://www.mida.org/posts/reactive-programming-in-financial-markets/

Used Package Manager

npm

System Info

Not relevant

[github-actions]

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

[meteorlxy]

Yep, markdown-it-anchor has provided multiple solutions for that since v8.0.

We didn't update to use other methods to get better a11y yet. Contribution welcome