Skip to content

fix(client): fix double quote in head tag #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix(client): fix double quote in head tag #1176

merged 1 commit into from
Dec 6, 2022
+1 −1

Conversation

tinyfind
Copy link
Contributor

@tinyfind tinyfind commented Dec 1, 2022

@Mister-Hope
Copy link
Member

Mister-Hope commented Dec 1, 2022 •
edited
Loading

You’d better explain why JSON.stringify is needed.

@Mister-Hope Mister-Hope closed this Dec 1, 2022
@Mister-Hope
Copy link
Member

Closing as this is not a valid fix, if attr contain space, you fix can cause similar issue.

@tinyfind
Copy link
Contributor Author

tinyfind commented Dec 2, 2022

Closing as this is not a valid fix, if attr contain space, you fix can cause similar issue.

sure? can you give me an example

@tinyfind
Copy link
Contributor Author

tinyfind commented Dec 2, 2022

You’d better explain why JSON.stringify is needed.

'some text with "double quote"' valid string
https://github.com/vuepress/vuepress-next/blob/8c345d827c758326429b20f37b6be95f0865c655/packages/client/src/setupUpdateHead.ts#L88
but here will transform that to "some text with "double quote""，it's invalid
so use "" or '' will generate invalid string,

@Mister-Hope

This comment was marked as off-topic.

Sign in to view
@Mister-Hope Mister-Hope reopened this Dec 2, 2022
@meteorlxy meteorlxy merged commit 69956c0 into vuepress:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mister-Hope Mister-Hope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] doule quote in head tag content cause issues in devServer
3 participants
@tinyfind @Mister-Hope @meteorlxy