Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support layouts option in client config #1053

Merged
merged 5 commits into from
Aug 26, 2022
Merged

feat: support layouts option in client config #1053

merged 5 commits into from
Aug 26, 2022

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Aug 25, 2022

BREAKING CHANGE: theme API layouts has been removed, theme layouts should be set in client config instead of theme entry
BREAKING CHANGE: 404 layout should be renamed to NotFound layout
BREAKING CHANGE: node API app.layouts has been removed

BREAKING CHANGE: now theme layouts should be set in client config instead of theme entry
@meteorlxy meteorlxy marked this pull request as ready for review August 26, 2022 15:27
@meteorlxy meteorlxy changed the title feat: set layouts in client config feat: support layouts option in client config Aug 26, 2022
@meteorlxy meteorlxy merged commit a67a0bf into main Aug 26, 2022
@meteorlxy meteorlxy deleted the layouts branch August 26, 2022 15:46
@devPaulRS
Copy link

@meteorlxy This breaks theme extends.

Child Theme Index.ts:
Screenshot from 2022-12-11 10-39-16

client.ts:
Screenshot from 2022-12-11 10-40-36

Error:

Failed to load url /home/node/app/docs/.vuepress/.temp/internal/layoutComponents (resolved id: /home/node/app/docs/.vuepress/.temp/internal/layoutComponents). Does the file exist?

Was fine before this, also the md states i can do it this way, but still gives the above error, am i doing something wrong?

@devPaulRS
Copy link

Also, the blitzstack needs to update to latest patch, as i can't use latest version there to show replication.

@Mister-Hope
Copy link
Member

You may open a issue with a minimal reproduction

@Mister-Hope
Copy link
Member

@meteorlxy I found this change awful, with this change, old layouts cannot be tree shaken even if they are overridden to new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants