Skip to content

Commit ca7daef

Browse files
authoredJul 8, 2022
fix(ssr/reactivity): fix array setting error at created in ssr [#12632] (#12633)
fix #12632
1 parent 15e6f1d commit ca7daef

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed
 

Diff for: ‎packages/server-renderer/test/ssr-reactivity.spec.ts

+4
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@ describe('SSR Reactive', () => {
9393

9494
set(state.value, 1, {})
9595
expect(isReactive(state.value[1])).toBe(true)
96+
97+
const rawArr = []
98+
set(rawArr, 1, {})
99+
expect(isReactive(rawArr[1])).toBe(false)
96100
})
97101

98102
// #550

Diff for: ‎src/core/observer/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ export function set(
241241
target.length = Math.max(target.length, key)
242242
target.splice(key, 1, val)
243243
// when mocking for SSR, array methods are not hijacked
244-
if (!ob.shallow && ob.mock) {
244+
if (ob && !ob.shallow && ob.mock) {
245245
observe(val, false, true)
246246
}
247247
return val

0 commit comments

Comments
 (0)
Please sign in to comment.