fix: does not pass data provided to mount to wrapper component #1750
+28
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1661 introduced copying of passed options to parent wrapper. However it fails in a weird way if you are using
data
option formount
/shallowMount
with external variable.i.e.
In this case
data
function will be invoked two times:Parent
component (wrapper for ourTestComponent
) - at this pointdefaultData
will be "poisoned" (will become reactive, and observed byParent
component for changes)Parent
wrapper will be mounted, causingTestComponent
instance to mount - at this point Vue will complainbecause
defaultData
is treated as$data
for Parent wrapper component alreadyIn general, we do not need setting
data
on parent wrapper, so I just eliminate this propety before copyingWhat kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch.fix #xxx[,#xxx]
, where "xxx" is the issue number)Other information: