Fix inconsistent hashes between Windows and POSIX systems #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the tests have failed due to anything I did. |
|
Okay, the CI error is caused because it uses I can fix the CI config on this branch, if need be. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
I did not add tests for my changes, but I did verify the fix works by making my webpack bundle on a Linux system, getting one ID or hash, then running the same files and configuration on a Windows system and getting a different hash.
If relevant, did you update the README?
No.
Summary
When using this loader on a project where we have Windows, Linux (and maybe OS X) users,
I discovered we were getting different bundles if one user bundled using a POSIX system, and another bundled the same files on a Windows system.
I believe I only encountered this issue when bundling in development mode.
Edit: You could say it's related to #19. It fixed the issue for different devices using the same system type. This PR fixes the same issue for different devices using different system types.
Does this PR introduce a breaking change?
I do not believe it is a breaking change.
Other information
I don't have an issue to link, however, I used this PR to test my fix.
It includes a fix for
vue-loaderas well, which I will open a PR for, soon.This is a simple issue, but if you think a reproduction setup is needed to see the issue in action, let me know and I'll it set up.