fix: lang='tsx' doesn't work for Vue 3 SFC
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lmiller1990 @cexbrayat could you check this PR? (Pinging you as I'm not sure if you already got a notification or not) |
|
LGTM (but I no longer actively maintain this as we switched to vitest to run our tests) |
|
I understand the reasoning. It would be great to have PRs for bug fixes reviewed and released. Because it’s not straightforward to switch to vitest especially in big monorepos |
|
I too do not really use / maintain this, but I will review and release your fix, give me until the end of the week (5th or 6th of Aug). We really need someone who is actively invested in this repo, for now I'm happy to do the minimum of review / release patches, but I only check when someone pings me. |
lmiller1990
approved these changes
Aug 6, 2023
|
@lmiller1990 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same fix that is added for Vue 2 with this PR: #395
Resolves #510