Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump json5 from 1.0.1 to 1.0.2 #526

Merged
merged 2 commits into from Aug 7, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2023

Bumps json5 from 1.0.1 to 1.0.2.

Release notes

Sourced from json5's releases.

v1.0.2

  • Fix: Properties with the name __proto__ are added to objects and arrays. (#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (#295). This has been backported to v1. (#298)
Changelog

Sourced from json5's changelog.

Unreleased [code, diff]

v2.2.3 [code, diff]

  • Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (#299)

v2.2.2 [code, diff]

  • Fix: Properties with the name __proto__ are added to objects and arrays. (#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (#295).

v2.2.1 [code, diff]

v2.2.0 [code, diff]

  • New: Accurate and documented TypeScript declarations are now included. There is no need to install @types/json5. (#236, #244)

v2.1.3 [code, diff]

  • Fix: An out of memory bug when parsing numbers has been fixed. (#228, #229)

v2.1.2 [code, diff]

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 7, 2023
@pgrenaud
Copy link

Would it be possible to look into this and bump json5 to fix the current high vulnerability?
https://www.npmjs.com/advisories/1088341

@jsspiegel
Copy link

@lmiller1990 Thank you for your work maintaining this repo, in the absence of a dedicated maintainer! Would it be possible for you to look into getting this PR merged and reviewed whenever you have a chance?

@lmiller1990
Copy link
Member

Sure, done. It will go in the next release.

This is only a dev dep, it shouldn't be installed when you install Vue Jest, right? So it wouldn't only be a vulnerability for someone working on this repo locally.

@lmiller1990 lmiller1990 merged commit ec74482 into master Aug 7, 2023
3 of 4 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/json5-1.0.2 branch August 7, 2023 00:00
@jsspiegel
Copy link

jsspiegel commented Aug 7, 2023

Ah, you're correct! My apologies, it looks like my organization is on an old version of vue-jest (v3.0.7) that still had an explicit non-dev dependency on json5 via find-babel-config. I got confused and thought that vue-jest still had a non-dev dependency on json5 and that this PR was necessary to resolve the vulnerability, but you're correct that json5 is now only a dev dependency. For some reason dependabot didn't detect that we could resolve the issue by upgrading to an existing newer version of vue-jest that removed the dependency on find-babel-config/json5 (perhaps because json5 is still technically in your lockfile) 🤔 Sorry for the inconvenience!

@lmiller1990
Copy link
Member

Try @vue/vue2-jest, that should be the most recent one for Vue 2.

@jsspiegel
Copy link

Try @vue/vue2-jest, that should be the most recent one for Vue 2.

Yep, that worked! Thanks so much for all of your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants