fix: fix static content removal for lean chunks due to Vue 3.5 changes #4508
+7
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/publish |
commit: |
yyx990803
commented
Jan 22, 2025
|
|
||
| return createRouter((path) => { | ||
| let pageFilePath = pathToFile(path) | ||
| let pageModule = null | ||
|
|
||
| if (pageFilePath) { | ||
| // use lean build if this is the initial page load |
There was a problem hiding this comment.
Because in 3.5 the static vnodes are cached per-instance instead of globally hoisted, we can no longer rely on adopted content during hydration when navigating back to the initial page. We have to load the full chunk here in that case.
brc-dd
approved these changes
Jan 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brc-dd we need to do some manual testing to make sure this works with Vue 3.4 and below (could be explicitly installed by user)
Also let's test this for Vue and Vite docs before releasing.