feat: upgrade markdown-it types to v14 #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorlxy
commented
Apr 10, 2024
| ], | ||
| "main": "", | ||
| - "types": "index.d.ts", | ||
| + "types": "index.d.mts", |
There was a problem hiding this comment.
Without this patch, tsc could pass but rollup-plugin-dts would throw an error.
This patch is to make rollup-plugin-dts work. Need more investigation for the root cause.
There was a problem hiding this comment.
Need more investigation for the root cause.
resolvedCompilerOptions seem to be always empty here - https://github.com/Swatinem/rollup-plugin-dts/blob/3835bfa27125db7fa5a9d071f0b93ec513d2664b/src/index.ts#L196
If we force moduleResolution bundler there then it resolves to correct files, but then the transform breaks polka by converting export default function<T to declare functionexport_default<T
brc-dd
reviewed
Apr 10, 2024
brc-dd
reviewed
Apr 10, 2024
brc-dd
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
@types/markdown-itand@mdit-vue/*