fix: hashchange should only be triggered for same page navigations #3768
+41
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niceplugin
added a commit
to niceplugin/vitepress-KO
that referenced
this pull request
Apr 21, 2024
niceplugin
added a commit
to niceplugin/vitepress-KO
that referenced
this pull request
Apr 21, 2024
* docs: add Stormkit as deployment platform (vuejs#3751) * docs: adjust install and init commands * docs: update default-theme sidebar type (vuejs#3715) * docs: make vue as peer dependency section clearer (vuejs#3687) * fix: hashchange should only be triggered for same page navigations (vuejs#3768) * chore: bump deps, lock mdit to v2.0 * release: v1.1.0 * build: set up sort-package-json * docs: added nginx deployment documentation (vuejs#3770)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts parts of f6bd99e...49ea062
The original implementation by zonemeen was correct - 59e1773
hashchangeshould not be triggered when navigating between different pagesThis PR also adds
hashproperty inuseDataoutput for those who want to watch for hash change while navigating between pages - say from/foo#barto/. Those who don't want this should stick withwindow.addEventListener('hashchange', ...)It also emits correct event instance with
oldURLandnewURLforhashchangenow.