Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ru): add Russian translation #3709

Merged
merged 49 commits into from
Apr 7, 2024
Merged

docs(ru): add Russian translation #3709

merged 49 commits into from
Apr 7, 2024

Conversation

dragomano
Copy link
Contributor

No description provided.

@awxiaoxian2020 awxiaoxian2020 added docs Improvements or additions to documentation translations labels Apr 1, 2024
@brc-dd
Copy link
Member

brc-dd commented Apr 1, 2024

Can someone who speaks Russian thoroughly review this once? We can merge it after that. You can probably announce this on your social media or ask for some help using discussions in the Vue Russian translation repo - https://github.com/vuejs-translations/docs-ru - or the Telegram group mentioned there.

And just FYI - this is the deploy preview URL - https://deploy-preview-3709--vitepress-docs.netlify.app/

Copy link
Contributor

@altrusl altrusl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cloned the repo and tested it running - looks fine
The translation looks ok

Copy link

@Leronez Leronez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks for the translation. I've reviewed a small part of it.


Все **статические** ссылки на пути, включая абсолютные пути, должны быть основаны на структуре ваших рабочих каталогов.

## Публичный каталог {#the-public-directory}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может быть лучше public так и оставить, чтобы была связь с реальным названием директории?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно. Вроде же нигде нельзя переопределить эту директорию?

docs/ru/guide/custom-theme.md Outdated Show resolved Hide resolved
docs/ru/guide/custom-theme.md Outdated Show resolved Hide resolved
docs/ru/guide/data-loading.md Outdated Show resolved Hide resolved
@Leronez
Copy link

Leronez commented Apr 4, 2024

@dragomano, what do you think about moving the fork for Russian translation to the https://github.com/translation-ru organization after this merge request is accepted?

It currently hosts the official pinia and vue-router translations.

@brc-dd
Copy link
Member

brc-dd commented Apr 4, 2024

Ah, if you want to keep it in your community org, we don't need to merge 👀 It'll be similar to how we have Korean translations here - externally linked. You can also remove the other translations and just keep Russian ones there.

@dragomano
Copy link
Contributor Author

No, I don't want to move the translations to a separate repository. It will be easier for me to support them here :)

@brc-dd brc-dd merged commit 5832402 into vuejs:main Apr 7, 2024
7 checks passed
@dragomano dragomano deleted the russian branch April 7, 2024 14:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to documentation translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants