fix(theme): improve contrast of search highlight text #2887
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the text
color
used for highlights within the local search. This is to improve the contrast in light mode.The screenshot below shows:
background-color
for highlights is the same for both light and dark mode.background-color
is using the green theme, which varies between dark and light mode. In light mode, both the text and background are dark.color
for the text in light mode is now white, for greater contrast with the background.I've used
--vp-c-neutral-inverse
for the text. I'm unclear if this is the correct variable, but it gives the desired result of black or white, depending on the current theme mode.